Fixes 1921 #1935
Merged
Fixes 1921 #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yObserver as destination if no 1921
…subscription error calling xhr.abort(). Possibly only an artifact of test utils, but after applying fix for ReactiveX#1921 started getting an error that xhr.abort() in AjaxObservable's unsubscribe call wasn't a function.
|
👏 excellent! LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supply the Subscriber constructor the empty observer destination if
Observable.subscribeis called with no arguments. This ensures the Subscriber wraps the empty Observer in aSafeSubscriberwhich will catcherrormessages and dispose of the subscription.Related issue (if exists):
#1921